fix(testing): strip relative paths (as well as file:// paths) from snapshot test subprocess stderr#7081
Open
dandv wants to merge 1 commit intodenoland:mainfrom
Open
fix(testing): strip relative paths (as well as file:// paths) from snapshot test subprocess stderr#7081dandv wants to merge 1 commit intodenoland:mainfrom
dandv wants to merge 1 commit intodenoland:mainfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7081 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 630 630
Lines 50490 50490
Branches 8949 8949
=======================================
+ Hits 47669 47670 +1
Misses 2249 2249
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dandv
force-pushed
the
fix-snapshot-test-check-regex
branch
from
34e4aeb to
a49aab4
Compare
dandv
force-pushed
the
fix-snapshot-test-check-regex
branch
from
a49aab4 to
83602d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7080.
formatTestErrorinsnapshot_test.tsstrips Deno'sCheck <path>diagnostic lines from subprocess stderr, but theregex only matched
file://URLs. Deno outputs file:// URLs when the working dir is 3+ levels from the filesystem root, but it outputs relative paths (e.g.../../tmp/…) when the working directory is fewer than 3 levels from /. That left the line unstripped and causedassertNoErrorto throw.This fix broadens the regex from
/^Check file:\/\/(.+)\n/gmto/^Check .+\n/gmso it matches any path format Deno emits.Authored with help from Claude 4.6.